Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: introduce isyncstore interface #660

Merged
merged 3 commits into from
May 17, 2023

Conversation

james-milligan
Copy link
Contributor

This PR

  • decouples the sync store from sync server startup, allowing for alternative sync store implementations to be introduced

Related Issues

Notes

Follow-up Tasks

How to test

Signed-off-by: James Milligan <[email protected]>
@james-milligan james-milligan requested a review from a team as a code owner May 17, 2023 10:18
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #660 (2a543c0) into main (93e708e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #660   +/-   ##
=======================================
  Coverage   72.98%   72.98%           
=======================================
  Files          24       24           
  Lines        2402     2402           
=======================================
  Hits         1753     1753           
  Misses        583      583           
  Partials       66       66           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: James Milligan <[email protected]>
Signed-off-by: James Milligan <[email protected]>
@james-milligan james-milligan merged commit c0e2fa0 into open-feature:main May 17, 2023
@github-actions github-actions bot mentioned this pull request May 17, 2023
beeme1mr pushed a commit that referenced this pull request Jun 7, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>flagd: 0.5.4</summary>

##
[0.5.4](flagd/v0.5.3...flagd/v0.5.4)
(2023-06-07)


### 🧹 Chore

* update otel dependencies
([#649](#649))
([2114e41](2114e41))


### 🐛 Bug Fixes

* **deps:** update module github.com/open-feature/flagd/core to v0.5.3
([#634](#634))
([1bc7e99](1bc7e99))
* **deps:** update module
github.com/open-feature/go-sdk-contrib/providers/flagd to v0.1.12
([#635](#635))
([fe88061](fe88061))
* **deps:** update module
github.com/open-feature/go-sdk-contrib/tests/flagd to v1.2.2
([#651](#651))
([9776973](9776973))


### ✨ New Features

* telemetry improvements
([#653](#653))
([ea02cba](ea02cba))


### 🔄 Refactoring

* introduce additional linting rules + fix discrepancies
([#616](#616))
([aef0b90](aef0b90))
</details>

<details><summary>flagd-proxy: 0.2.4</summary>

##
[0.2.4](flagd-proxy/v0.2.3...flagd-proxy/v0.2.4)
(2023-06-07)


### 🐛 Bug Fixes

* **deps:** update module github.com/open-feature/flagd/core to v0.5.3
([#634](#634))
([1bc7e99](1bc7e99))


### 🧹 Chore

* update otel dependencies
([#649](#649))
([2114e41](2114e41))


### ✨ New Features

* telemetry improvements
([#653](#653))
([ea02cba](ea02cba))


### 🔄 Refactoring

* introduce additional linting rules + fix discrepancies
([#616](#616))
([aef0b90](aef0b90))
* introduce isyncstore interface
([#660](#660))
([c0e2fa0](c0e2fa0))
</details>

<details><summary>core: 0.5.4</summary>

##
[0.5.4](core/v0.5.3...core/v0.5.4)
(2023-06-07)


### ✨ New Features

* add `sem_ver` jsonLogic evaluator
([#675](#675))
([a8d8ab6](a8d8ab6))
* add `starts_with` and `ends_with` json evaluators
([#658](#658))
([f932b8f](f932b8f))
* telemetry improvements
([#653](#653))
([ea02cba](ea02cba))


### 🐛 Bug Fixes

* **deps:** update module github.com/bufbuild/connect-go to v1.8.0
([#683](#683))
([13bb13d](13bb13d))
* **deps:** update module github.com/bufbuild/connect-opentelemetry-go
to v0.3.0 ([#669](#669))
([e899435](e899435))
* **deps:** update module github.com/prometheus/client_golang to v1.15.1
([#636](#636))
([b22279d](b22279d))
* **deps:** update module github.com/stretchr/testify to v1.8.3
([#662](#662))
([2e06d58](2e06d58))
* **deps:** update module github.com/stretchr/testify to v1.8.4
([#678](#678))
([ca8c9d6](ca8c9d6))
* **deps:** update module golang.org/x/mod to v0.10.0
([#682](#682))
([16199ce](16199ce))
* **deps:** update module golang.org/x/net to v0.10.0
([#644](#644))
([ccd9d35](ccd9d35))
* **deps:** update module golang.org/x/sync to v0.2.0
([#638](#638))
([7f4a7db](7f4a7db))
* **deps:** update module google.golang.org/grpc to v1.55.0
([#640](#640))
([c0d7328](c0d7328))
* **deps:** update module sigs.k8s.io/controller-runtime to v0.15.0
([#665](#665))
([9490ed6](9490ed6))
* fix connect error code handling for disabled flags
([#670](#670))
([86a8012](86a8012))
* remove disabled flags from bulk evaluation
([#672](#672))
([d2ce988](d2ce988))


### 🔄 Refactoring

* introduce additional linting rules + fix discrepancies
([#616](#616))
([aef0b90](aef0b90))
* introduce isyncstore interface
([#660](#660))
([c0e2fa0](c0e2fa0))


### 🧹 Chore

* refactor json logic evaluator to pass custom operators as options
([#691](#691))
([1c9bff9](1c9bff9))
* update otel dependencies
([#649](#649))
([2114e41](2114e41))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants